This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] sim: mn10300: fix typo in if check

From: Stan Shebs <stanshebs at earthlink dot net>
To: gdb-patches at sourceware dot org, Kevin Buettner <kevinb at redhat dot com>
Date: Mon, 07 Nov 2011 16:18:23 -0800
Subject: Re: [PATCH] sim: mn10300: fix typo in if check
References: <1320564730-24857-1-git-send-email-vapier@gentoo.org> <20111107160845.GF14508@adacore.com>

On 11/7/11 8:08 AM, Joel Brobecker wrote:

The code looks like it should be doing a bit check, not logical.
2011-11-06  Mike Frysinger<vapier@gentoo.org>

	PR sim/9302
	* dv-mn103iop.c (write_dedicated_control_reg): Convert&&  to&.

Indeed. I don't know this processor, and I couldn't easily find
an architecture manual for it.  But the combination of the&&  being
a nop, and the error message themselves, leads me to agree with you.
I would have asked someone familiar with the architecture, but this
file hasn't been touched since day 1 of the public CVS.

With Michael's passing, mn10300 is left nominally unmaintained. Kevin, I notice you touched the target-specific code last, but it was a while ago. Is this chip still in use? If so, can you take up maintenance for it? Is there still a working Linux port, so mn10300-linux-tdep.c gets exercised?

Stan
stan@codesourcery.com

References:
- [PATCH] sim: mn10300: fix typo in if check
  - From: Mike Frysinger
- Re: [PATCH] sim: mn10300: fix typo in if check
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]