This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] read_frame_register_value and big endian arches
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 7 Nov 2011 13:24:20 -0800
- Subject: Re: [RFA] read_frame_register_value and big endian arches
- References: <20111026213726.GV19246@adacore.com> <1320022996-14705-1-git-send-email-brobecker@adacore.com> <201111071941.41988.pedro@codesourcery.com>
Hi Pedro,
> > gdb/ChangeLog:
> >
> > * findvar.c (read_frame_register_value): Read the correct bytes
> > from registers on big-endian architectures.
>
> Looks good to me.
Thanks for double-checking my change...
> > +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug optimize=-O1]] != "" } {
>
> Does the test really depend on the compiler doing the right optimizations?
Yes. I haven't looked at the unoptimized version, but my guess is
that the parameter value gets immediately pushed to the stack, thus
hiding the problem.
--
Joel