Re: Status of 'blacklist' patch?

["Maciej W. Rozycki" <macro at codesourcery dot com>]

On Tue, 1 Nov 2011, Justin Lebar wrote:

> Checked in, with two spaces after periods in comments.
> 
> Thank you for your patience!
> 
> -Justin
> 
> 2011-10-06  Justin Lebar  <justin.lebar@gmail.com>
> 
> 	* Makefile.in: (SFILES): Add skip.c.
> 	(HFILES_NO_SRCDIR): Add skip.h.
> 	(COMMON_OBS): Add skip.o.
> 	* skip.h, skip.c: New.
> 	* breakpoint.h (set_default_breakpoint): Remove.
> 	(get_sal_arch): Declare.
> 	* breakpoint.c: Remove default_breakpoint_valid,
> 	default_breakpoint_address, default_breakpoint_symtab,
> 	default_breakpoint_line, default_breakpoint_pspace variables.
> 	(get_sal_arch): Make public.
> 	(set_default_breakpoint): Remove.
> 	(parse_breakpoint_sals, create_breakpoint, clear_command,
> 	decode_line_spec_1): Remove uses of default_breakpoint variables;
> 	replaced with function calls into stack.c.
> 	* cli/cli-cmds.h: Add cmd_list_element *skiplist.
> 	* cli/cli-cmds.c: Add skiplist.
> 	(init_cmd_lists): Initialize skiplist.
> 	(init_cli_cmds): Fix comment (classes of commands appear in
> 	alphabetical order).
> 	* infrun.c (handle_inferior_event): Add check that we don't step into
> 	a function whose pc is marked for skip.
> 	* stack.c: Declare last_displayed_sal_valid, last_displayed_pspace,
> 	last_displayed_addr, last_displayed_symtab, last_displayed_line
> 	variables.
> 	(set_last_displayed_sal): New static function.
> 	(print_frame_info): Switch call to set_default_breakpoint to call to
> 	set_last_displayed_sal.
> 	(clear_last_displayed_sal, last_displayed_sal_is_valid,
> 	get_last_displayed_pspace, get_last_displayed_addr,
> 	get_last_displayed_symtab, get_last_displayed_line,
> 	get_last_displayed_sal): New public functions.
> 	* stack.h (clear_last_displayed_sal, last_displayed_sal_is_valid,
> 	get_last_displayed_pspace, get_last_displayed_addr,
> 	get_last_displayed_symtab, get_last_displayed_line,
> 	get_last_displayed_sal): Declare.
> 
> 2011-10-06  Justin Lebar <justin.lebar@gmail.com>
> 
> 	Add tests for skip command.
> 	* testsuite/gdb.base/skip-solib-lib.c: New
> 	* testsuite/gdb.base/skip-solib-main.c: New
> 	* testsuite/gdb.base/skip-solib.exp: New
> 	* testsuite/gdb.base/skip.c: New
> 	* testsuite/gdb.base/skip.exp: New
> 	* testsuite/gdb.base/skip1.c: New
> 	* testsuite/gdb.base/Makefile.in: Adding new files.

 This change broke the build of gdb.info:

makeinfo --css-ref=../cs.css --split-size=5000000 --split-size=5000000 --split-size=5000000 -DHAVE_MAKEINFO_CLICK -I .../gdb/doc/../../readline/doc -I .../gdb/doc/../mi -I .../gdb/doc \
                -o gdb.info .../gdb/doc/gdb.texinfo
.../gdb/doc/gdb.texinfo:4899: warning: `.' or `,' must follow @xref, not `I'.
.../gdb/doc/gdb.texinfo:4857: `Skipping Over Functions and Files' has no Up field(perhaps incorrect sectioning?).
.../gdb/doc/gdb.texinfo:4857: warning: unreferenced node `Skipping Over Functionsand Files'.
makeinfo: Removing output file `gdb.info' due to errors; use --force to preserve.
make[5]: *** [gdb.info] Error 1

Also a ChangeLog entry is missing for changes to gdb.texinfo -- please fix 
that up.

 OK to apply the fix for the build errors below?

2011-11-02  Maciej W. Rozycki  <macro@codesourcery.com>

	gdb/doc/
	* gdb.texinfo (Skipping Over Functions and Files): Remove node 
	designation.  Fix "Specify Location" cross-reference.

  Maciej

gdb-info-fix.diff
Index: gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/doc/gdb.texinfo	2011-11-02 21:25:50.000000000 +0000
+++ gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo	2011-11-02 22:22:53.495572496 +0000
@@ -4854,7 +4854,6 @@ proceed until the function returns.
 An argument is a repeat count, as in @code{next}.
 @end table
 
-@node Skipping Over Functions and Files
 @subsection Skipping Over Functions and Files
 @cindex skipping over functions and files
 
@@ -4896,7 +4895,7 @@ example, @code{skip file boring.c}.
 @itemx skip function @r{[}@var{linespec}@r{]}
 After running this command, the function named by @var{linespec} or the
 function containing the line named by @var{linespec} will be skipped over when
-stepping.  @xref{Specify Location}
+stepping.  @xref{Specify Location}.
 
 If you do not specify @var{linespec}, the function you're currently debugging
 will be skipped.