This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] [patch] PR python/13331
- From: Tom Tromey <tromey at redhat dot com>
- To: pmuldoon at redhat dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Oct 2011 07:49:36 -0600
- Subject: Re: [python] [patch] PR python/13331
- References: <m3ipne7chg.fsf@redhat.com>
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> 2011-10-24 Phil Muldoon <pmuldoon@redhat.com>
Phil> PR python/13331
Phil> * python/py-function.c (fnpy_call): Check 'args' is not NULL.
Phil> (convert_values_to_python): Return on Python tuple allocation
Phil> failure.
Phil> + if (! result)
Phil> + return NULL;
I think the function should have a single return convention.
One easy way to do that would be to remove the 'error' call and have it
return NULL when value_to_value_object fails.
Tom