This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7] Introduce jit-reader.in and modify build system.
>>>>> "Sanjoy" == Sanjoy Das <sanjoy@playingwithpointers.com> writes:
Sanjoy> jit-reader.in will host the interface to be implemented and the API to
Sanjoy> be used by the reader. The file needs to be processed by ./configure
Sanjoy> to produce `jit.reader.h'; so that GDB_CORE_ADDR is defined correctly.
Thanks for persevering with this patch series.
I think it is an important addition to gdb.
Sanjoy> gdb/ChangeLog:
Sanjoy> * gdb/Makefile.in: Add jit-reader.h as a header. Have it
Sanjoy> installed in $(includedir)/gdb.
Sanjoy> * gdb/configure.ac: Genereate a correct value for TARGET_PTR for
Sanjoy> jit-reader.h. Tell configure to generate jit-reader.h from
Sanjoy> jit-reader.in.
Sanjoy> * gdb/configure: Re-generated by autoconf.
Sanjoy> * gdb/jit-reader.in: New file.
Sanjoy> * gdb/jit.c: Include jit-reader.h.
One final nit from me on this patch.
Sanjoy> + $(SHELL) $(srcdir)/../mkinstalldirs $(includedir)/gdb ; \
Sanjoy> + $(INSTALL_DATA) jit-reader.h $(includedir)/gdb/jit-reader.h
This should have $(DESTDIR) in it, see the rest of this rule.
This patch is ok with this change.
I haven't been keeping track of your assignment status.
Has everything gone through?
Tom