This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target]
> Date: Sun, 28 Aug 2011 22:06:40 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote:
> > That is wrong for x32. X32 isn't LP64, but has 64bit registers.
>
> x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
Uh, that's wrong. The middle part if the target triplet is supposed
to be the hardware vendor. For i386/amd64 this is pretty much
meaningles, but attaching a new meaning to it would be a mistake.
Fortunately, your diff doesn't really depend on this. But I think you
should adjust the comments in the code.
> gdb/testsuite/
> 2011-08-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix compatibility with x32 arch.
> * testsuite/gdb.dwarf2/typeddwarf.exp: Check also is_lp64_target.
> * testsuite/gdb.trace/backtrace.exp: Use is_amd64_regs_target and
> is_x86_like_target.
> * testsuite/gdb.trace/collection.exp: Likewise.
> * testsuite/gdb.trace/report.exp: Likewise.
> * testsuite/gdb.trace/unavailable.exp: Likewise.
> * testsuite/gdb.trace/while-dyn.exp: Likewise.
> * testsuite/lib/gdb.exp (is_amd64_regs_target): New function.
> (is_x86_like_target): Check also is_amd64_regs_target.