This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] 12843

On 2011-8-27 16:44, Eli Zaretskii wrote:
What about these:

  break 'file with spaces.c:function:with:colons'
  break 'file with spaces.c':'function:with:colons'
I would expect only the second one is valid.

This patch checks if ':' is followed by '/' and/or '\\' (depending on definition of IS_DIR_SEPARATOR). If it is, we keep looking for the next terminal in the string. This is problematic for filenames with ":\\" or "://" in them, but locate_first_half has gotten those wrong for a long, long time (in fact, any filename at all with a colon(s) in it).

Let's revert back to the old and wrong way. ^_^, the patch should works fine under Windows, because no extra colons is allowed in file names there.

asmwarrior
ollydbg from codeblocks' forum

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]