This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move common linux procfs code to common/


On Tuesday 23 August 2011 14:51:14, Luis Machado wrote:
> Hi,
> 
> This patch moves the linux procfs-related function "linux_proc_get_tgid" 
> to the common subdirectory so GDBServer can use it as well, avoiding 
> duplicated code.
> 
> This is a preparation for the next GDBServer patch i will submit shortly.
> 
> If there are no objections, i will check it in at the end of the day.

Saying "pre-approved by Foo offlist" is more usual in such cases.

FAOD, this is okay.

On Tuesday 23 August 2011 14:51:14, Luis Machado wrote:
> -linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(server_h) $(linux_osdata_h)
> +linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(linux_procfs_h) \
> +       $(server_h) $(linux_osdata_h)
>         $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@

Ah, this should be part of the other patch, not this one.  linux-low.c was
not changed in this patch.  Please move this hunk to the other patch
before committing.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]