This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move common linux procfs code to common/
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org, lgustavo at codesourcery dot com
- Date: Tue, 23 Aug 2011 18:58:31 +0100
- Subject: Re: [PATCH] Move common linux procfs code to common/
- References: <4E53B052.8030006@codesourcery.com>
On Tuesday 23 August 2011 14:51:14, Luis Machado wrote:
> Hi,
>
> This patch moves the linux procfs-related function "linux_proc_get_tgid"
> to the common subdirectory so GDBServer can use it as well, avoiding
> duplicated code.
>
> This is a preparation for the next GDBServer patch i will submit shortly.
>
> If there are no objections, i will check it in at the end of the day.
Saying "pre-approved by Foo offlist" is more usual in such cases.
FAOD, this is okay.
On Tuesday 23 August 2011 14:51:14, Luis Machado wrote:
> -linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(server_h) $(linux_osdata_h)
> +linux-low.o: linux-low.c $(linux_low_h) $(linux_ptrace_h) $(linux_procfs_h) \
> + $(server_h) $(linux_osdata_h)
> $(CC) -c $(CPPFLAGS) $(INTERNAL_CFLAGS) $< @USE_THREAD_DB@
Ah, this should be part of the other patch, not this one. linux-low.c was
not changed in this patch. Please move this hunk to the other patch
before committing.
--
Pedro Alves