This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] append_composite_type_field_aligned
- From: Tom Tromey <tromey at redhat dot com>
- To: "Andrew Burgess" <aburgess at broadcom dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 22 Jun 2011 13:54:38 -0600
- Subject: Re: [PATCH] append_composite_type_field_aligned
- References: <4DF0E83C.8010600@broadcom.com>
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
I'm sorry about the delay on this.
Pinging was the right thing to do -- thank you.
Andrew> 2011-06-09 Andrew Burgess <aburgess@broadcom.com>
Andrew> * gdbtypes.c (append_composite_type_field_aligned): Fix
Andrew> calculation of bit position based on alignment.
Ok with one nit..
Andrew> + int left;
Andrew> + alignment *= TARGET_CHAR_BIT;
Blank line between declarations and code.
Tom