This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb.mi/mi-nsintrall.exp: fix racy tests (PR testsuite/12649)


>>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:

Marek> The troublemakers here were two gdb_test_multiple tests.  Thus, I've
Marek> converted them into the mi_gdb_test.  OK?

Marek> 2011-06-20  Marek Polacek  <mpolacek@redhat.com>
Marek>         * gdb.mi/mi-nsintrall.exp: Replace gdb_test_multiple with mi_gdb_test.

Looks good, just a nit...

Marek> +mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all, no breakpoint"
 
Please break the line before the final argument, like:

mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" \
    "resume all, no breakpoint"


Marek> +mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all after interrupting"

Here too.

Ok with this change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]