This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] gdb.mi/mi-nsintrall.exp: fix racy tests (PR testsuite/12649)


The troublemakers here were two gdb_test_multiple tests.  Thus, I've
converted them into the mi_gdb_test.  OK?

2011-06-20  Marek Polacek  <mpolacek@redhat.com>

        * gdb.mi/mi-nsintrall.exp: Replace gdb_test_multiple with mi_gdb_test.

--- gdb/gdb/testsuite/gdb.mi/mi-nsintrall.exp.mp        2011-06-20 15:10:37.363577043 +0200
+++ gdb/gdb/testsuite/gdb.mi/mi-nsintrall.exp   2011-06-20 16:25:29.118829262 +0200
@@ -60,16 +60,16 @@ mi_check_thread_states \
 # now that we know about all the threads, we can get rid of the breakpoints
 mi_delete_breakpoints
 
+# Here we create a response string.  Note we don't want \r\n at the end,
+# since mi_gdb_test will append this itself.
 set running_re ""
-for {set i 6} {$i > 0} {incr i -1} {
+for {set i 6} {$i > 1} {incr i -1} {
     set running_re "$running_re\\*running,thread-id=\"$i\"\r\n"
 }
+set running_re "$running_re\\*running,thread-id=\"1\""
+
+mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all, no breakpoint"
 
-gdb_test_multiple "-exec-continue --all" "resume all, no breakpoint" {
-    -re ".*$running_re$mi_gdb_prompt" {
-       pass "resume all, no breakpoint"
-    }
-}
 mi_check_thread_states \
     {"running" "running" "running" "running" "running" "running"} \
     "thread state, resume all"
@@ -84,11 +84,7 @@ mi_check_thread_states \
     "thread state, all interrupted"
 
 # resume all threads, and check that no thread is spuriously left interrupted
-gdb_test_multiple "-exec-continue --all" "resume all after interrupting" {
-    -re ".*$running_re$mi_gdb_prompt" {
-       pass "resume all after interrupting"
-    }
-}
+mi_gdb_test "-exec-continue --all" "\[^\n\]*\r\n$running_re" "resume all after interrupting"
 
 sleep 1
 mi_check_thread_states \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]