This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Remove HAVE_UINTPTR_T from gdb_thread_db.h


>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Thiago> I'm not familiar with gdbserver but would it make sense to make
Thiago> gdbserver internally use the target_ops vector? That would make GDB's
Thiago> -nat.c files usable without modification in gdbserver. Then it would be
Thiago> a matter of porting the gdbserver's additional features which GDB native
Thiago> doesn't have.

The idea makes sense; I think it is among those discussed in previous
threads on this topic.

The devil is in the details.  The *-nat.c files are free to use any
other facility provided by gdb.  So, perhaps this approach would bloat
gdbserver excessively.

At least, I believe that is the standard objection.  I have not
investigated the problem myself.  My view is somewhat more meta: I think
merging the two makes sense, just to avoid the "double patch" problem,
and an important quality is the maintainability of the result; but the
exact path to get there I think it up to whoever does the work.

On this basis, I think Yao's approach, as communicated on the wiki,
seems reasonable.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]