This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] aix: add support for dwarf2.
>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
Tristan> + if (this_symtab_psymtab == NULL)
Tristan> + return;
Tom> I don't understand this change.
Tristan> This is just a guard. process_linenos (called by
Tristan> aix_process_linenos) will dereference this_symtab_psymtab,
Tristan> which is set by read_xcoff_symtab. However, if the psymtab is
Tristan> built by dwarf2, the variable will never be initialized.
Tristan> Do you think the issue is somewhere else ?
It is very unclear to me whether this can be non-NULL even with DWARF.
In the DWARF case wouldn't the line information come from the DWARF line
table? In which case it seems like xcoffread.c should have a second
struct sym_fns, with a NULL entry for this method.
Tom