This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/4] aix: add support for dwarf2.


On May 23, 2011, at 5:49 PM, Tom Tromey wrote:

>>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
> 
> Tristan>  static void
> Tristan>  aix_process_linenos (void)
> Tristan>  {
> Tristan> +  if (this_symtab_psymtab == NULL)
> Tristan> +    return;
> 
> I don't understand this change.

This is just a guard.
process_linenos (called by aix_process_linenos) will dereference this_symtab_psymtab, which is set by read_xcoff_symtab.
However, if the psymtab is built by dwarf2, the variable will never be initialized.

Do you think the issue is somewhere else ?

> 
> The rest looks ok to me.

Thank you for reviewing.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]