This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [doc RFA]: New option --with-iconv-bin


On Mon, May 9, 2011 at 2:08 PM, Doug Evans <dje@google.com> wrote:
> On Mon, May 9, 2011 at 1:36 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> Date: Mon, 9 May 2011 13:19:56 -0700
>>> From: Doug Evans <dje@google.com>
>>> Cc: gdb-patches@sourceware.org
>>>
>>> > Why not just say "if your @command{iconv} program is installed in a
>>> > non-standard place, you will need to tell @value{GDBN} where to find
>>> > it."?
>>> >
>>>
>>> The iconv program comes from glibc, but you're right, it doesn't
>>> *necessarily* come from there.
>>>
>>> How about this?
>>
>> It's fine, but...
>>
>>> +If @value{GDBN} is using the @code{iconv} program and it is installed in
>>> +a non-standard place, you will need to tell @value{GDBN} where to find it.
>>
>> The first "it" is ambiguous: it could have meant GDB or iconv.
>
> Yeah, I recognized the ambiguity in earlier versions and explicitly
> tried a couple of variations to avoid the ambiguity.
> I like what I came up with but it can always be improved of course.
>
>> Suggest a slight rephrase:
>>
>> ?If @value{GDBN} is using the @code{iconv} program which is installed
>> ?in a non-standard place, ...
>
> Ok.
>

Here is the patch I checked in.

Attachment: gdb-110509-with-iconv-bin-3.patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]