This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Support for x86 on-stack trampolines


One think I noted on a quick skim over the patch:

On Wednesday 04 May 2011 01:20:24, Jerome Guitton wrote:
> +static const struct frame_unwind i386_stack_tramp_frame_unwind =
> +{
> +  NORMAL_FRAME,
> +  default_frame_unwind_stop_reason,

default_frame_unwind_stop_reason is only used by 
archs/targets that don't support tracepoints at the moment.
It shouldn't be used in any x86-specific unwinder.

If you reuse the this _frame_this_id method of the
epilogue unwinder, you should reuse the _unwind_stop_reason
method of the same unwinder, since you're effectively
also reusing i386_epilogue_frame_cache.

> +  i386_epilogue_frame_this_id,
> +  i386_frame_prev_register,
> +  NULL, 
> +  i386_stack_tramp_frame_sniffer
> +};
> +

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]