This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] arm reversible : <phase_2_complete>
- From: Tom Tromey <tromey at redhat dot com>
- To: Petr HluzÃn <petr dot hluzin at gmail dot com>
- Cc: paawan oza <paawan1982 at yahoo dot com>, gdb at sourceware dot org, gdb-patches at sourceware dot org
- Date: Mon, 02 May 2011 08:46:42 -0600
- Subject: Re: [PATCH] arm reversible : <phase_2_complete>
- References: <341905.10459.qm@web112513.mail.gq1.yahoo.com> <m3d3m8xdf7.fsf@fleche.redhat.com> <208397.95006.qm@web112517.mail.gq1.yahoo.com> <4DA27006.1080607@codesourcery.com> <763549.92092.qm@web112506.mail.gq1.yahoo.com> <335149.24692.qm@web112515.mail.gq1.yahoo.com> <BANLkTik+_-KcX+=vVOeqwX-FNxYkQuEzXA@mail.gmail.com> <592215.58786.qm@web112508.mail.gq1.yahoo.com> <172713.29831.qm@web112503.mail.gq1.yahoo.com> <BANLkTin0hycedjgPRDHO7exEhS0SGQw3qQ@mail.gmail.com>
>>>>> "Petr" == Petr HluzÃn <petr.hluzin@gmail.com> writes:
Petr> I also recommend to define a local variable in the smalles scope
Petr> possible, however I understand that many
Petr> programmers use weak tools and knowing its definition requires more
Petr> effort than placing cursor on the variable - therefore they prefer
Petr> definitions at the start of function.
I agree, using the smallest scope is generally preferable.
This practice makes it simpler to reason about the code.
Petr> My IDE has a spellchecker which underlines typos. No effort required.
Petr> (Consider upgrading your tools.)
I'm curious to know what IDE you use for working on GDB.
For those using Emacs, M-x flyspell-prog-mode will spell-check in
comments and strings.
Petr> Also I have no vote in GDB development, so my patch approval would
Petr> have little impact.
I appreciate thoughtful reviews from anyone, regardless of their
official status. I think GDB patches still spend too much time waiting
for review, and this sort of thing can help speed things up.
Petr> GDB commiters: please reply whether you agree with my review. (So that
Petr> paawan oza does not spend effort in vain.)
I thought it was quite good. Thanks for doing this.
Tom