This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: print_npx_status_word
- From: Tom Tromey <tromey at redhat dot com>
- To: "Baars\, M.J." <mjbaars1977 dot gdb at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 19 Apr 2011 14:10:47 -0600
- Subject: Re: print_npx_status_word
- References: <4DA7166F.10302@gmail.com> <m3aafshl6l.fsf@fleche.redhat.com> <4DA7ED79.3000400@gmail.com> <m3ei53efd8.fsf@fleche.redhat.com> <4DA87235.7060003@gmail.com> <m3pqoncw78.fsf@fleche.redhat.com> <4DA87479.50203@gmail.com> <m3lizbcvt7.fsf@fleche.redhat.com> <4DA93270.6030708@gmail.com> <201104160824.p3G8ONWV006175@glazunov.sibelius.xs4all.nl> <4DA99DA1.2090708__5871.13250880993$1302961604$gmane$org@gmail.com> <m3liz78pak.fsf@fleche.redhat.com> <4DADDBE2.8050704@gmail.com>
Tom> As others have noted, ChangeLog is "prepend only".
Tom> We generally don't edit old entries.
Michael> As I stated before, it would be unwise though to keep unmaintained
Michael> function names in the log entries. You can apply the changes
Michael> optionally, but I strongly advise against retaining the original log
Michael> entries.
The log is just that, a log. Think of it as a primitive version of VC
commit messages. It is a document describe a sequence of changes, not a
document describing the current state of the source -- the source itself
plays that role.
Michael> If you don't like the indentation, I suggest you instead modify
Michael> you tab-settings locally. Personally I'm used programming with
Michael> a little more space than.
The usual rule in all projects is "consistent is better than good".
GDB fixed the basics of its style many years ago, for better or worse.
So, please conform to the prevailing style.
Tom> No `//' comments.
Michael> I have taken this into account, does that also hold for inline
Michael> comments?
Yes. GDB is mostly on C89. This is fairly typical in the GNU tools.
Tom