This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c


On Tuesday 19 April 2011 11:41:34, Pierre Muller wrote:
> --- xstormy16-tdep.c    18 Mar 2011 18:52:32 -0000      1.114
> +++ xstormy16-tdep.c    19 Apr 2011 10:35:47 -0000
> @@ -264,11 +264,9 @@ xstormy16_push_dummy_call (struct gdbarc
>        val = value_contents (args[i]);
>        for (j = 0; j < typelen; j += xstormy16_reg_size)
>         regcache_cooked_write_unsigned (regcache, argreg++,
> -                       extract_unsigned_integer (val + j,
> -                                                 typelen - j ==
> -                                                 1 ? 1 :
> -                                                 xstormy16_reg_size,
> -                                                 byte_order));
> +         extract_unsigned_integer (val + j,
> +                                   typelen - j == 1 ? 1 :
> xstormy16_reg_size,
> +                                   byte_order));

A sign that temporary variables would help, IMO:

       for (j = 0; j < typelen; j += xstormy16_reg_size)
		  {
	       ULONGEST regval;
          int size;

			size = typelen - j == 1 ? 1 : xstormy16_reg_size;
          val = extract_unsigned_integer (val + j, size, byte_order);
          regcache_cooked_write_unsigned (regcache, argreg++, regval);
         );

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]