This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: FYI: remove some dead code from source.c
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 04 Apr 2011 20:23:27 +0300
- Subject: Re: FYI: remove some dead code from source.c
- References: <m3oc4mgkx5.fsf@fleche.redhat.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 04 Apr 2011 08:17:58 -0600
>
> While looking into another patch, I ran across some dead code in
> source.c. Some of it is wrapped in `#if 0', and the rest in
> LSEEK_NOT_LINEAR, which AFAICT is never defined.
It was once defined in the DJGPP build, but then the DJGPP
implementation of the buffered I/O (a.k.a. stdio) functions was
modified so that it was no longer needed.
However, I wonder whether this works with MinGW. AFAIK, the Microsoft
implementation of lseek still suffers from this "non-linear" behavior,
due to the CR-LF end-of-line format. I would encourage that
Someone(TM) take a look at this.