This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Remove START_INFERIOR_TRAPS_EXPECTED macro from nm header
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: pedro at codesourcery dot com
- Cc: gdb-patches at sourceware dot org, pierre dot muller at ics-cnrs dot unistra dot fr
- Date: Tue, 22 Mar 2011 11:23:33 +0100 (CET)
- Subject: Re: [RFC] Remove START_INFERIOR_TRAPS_EXPECTED macro from nm header
- References: <003e01cbe825$321015a0$963040e0$@muller@ics-cnrs.unistra.fr> <201103220934.26493.pedro@codesourcery.com>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 22 Mar 2011 09:34:26 +0000
>
> Why's this any better? I claim that it's worse.
> START_INFERIOR_TRAPS_EXPECTED isn't ever used by anything
> outside of the native target backend implementation ---
> it doesn't qualify in the set of macros that are evil for
> a multi-arch gdb. Then, nothing in common code _should_
> know about how many internal traps are expected
> during startup_inferior, but you've just exposed that
> detail with to_start_inferior_traps_expected.
I have to agree with Pedro here.
If you really think that getting rid of the nm header files is
something that has to be done (I'm not convinced it is), then perhaps
you should simply add:
MH_CFLAGS=-DSTART_INFERIOR_TRAPS_EXPECTED=3
to the appropriate Makefile fragments. I'm not convinced that is an
improvmenet though.