This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Clear GREP_OPTIONS environment variable.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Andrew Burgess <aburgess at broadcom dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 16 Mar 2011 09:14:35 -0700
- Subject: Re: [PATCH] Clear GREP_OPTIONS environment variable.
- References: <4D807468.8020703@broadcom.com> <m3d3lr5bqy.fsf@fleche.redhat.com>
> Andrew> The test gdb.base/maint.exp shells out from gdb to use grep. I
> Andrew> have GREP_OPTIONS="--color=auto" in my environment and this
> Andrew> causes the test to fail. The patch below clears this environment
> Andrew> variable before running gdb. Ok to apply?
>
> Andrew> 2011-03-15 Andrew Burgess <aburgess@broadcom.com>
> Andrew> * lib/gdb.exp (default_gdb_start): Clear the GREP_OPTIONS
> Andrew> environment variable to make grep output more predictable.
>
> Ok.
I think that this is OK too. However, I'm wondering whether, as
a followup, we should be moving this type of code to the gdb_init
routine, rather than putting it there. The idea is to run this
once per testcase, rather than once everytime we start a new GDB
process.
--
Joel