This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA-v2] Fix ARI warning about function call in first column
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'Eli Zaretskii'" <eliz at gnu dot org>, <gdb-patches at sourceware dot org>
- Date: Mon, 14 Mar 2011 10:27:09 -0600
- Subject: Re: [RFA-v2] Fix ARI warning about function call in first column
- References: <20110312015329.GA20179@sourceware.org> <010f01cbe157$aebb5cb0$0c321610$@muller@ics-cnrs.unistra.fr> <18667.385276831$1300008680@news.gmane.org> <m3vczldagl.fsf@fleche.redhat.com> <001401cbe261$5490ec40$fdb2c4c0$@muller@ics-cnrs.unistra.fr>
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> As Eli had some concerns about that part,
Pierre> I tried to change my patch so that it does add new
Pierre> function declarations split in between return type and
Pierre> function name.
If you want, you can commit the obviously ok ones in the meantime.
Nearly all of your patch seems uncontroversial.
Pierre> -extern PyObject *
Pierre> -create_breakpoint_event_object (PyObject *breakpoint);
Pierre> +extern PyObject * create_breakpoint_event_object (PyObject *breakpoint);
Pierre> -extern PyObject *
Pierre> -create_signal_event_object (enum target_signal stop_signal);
Pierre> +extern PyObject * create_signal_event_object (enum target_signal
Pierre> stop_signal);
No space after the "*" in these two.
Tom