This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] completer.c (expression_completer): Stop memory leak.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 09 Mar 2011 10:58:30 -0800
- Subject: [RFA] completer.c (expression_completer): Stop memory leak.
In this case, it is possible for fieldname to be allocated before an
exception is thrown.
OK?
2011-03-09 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
* completer.c (expression_completer): Stop memory leak.
Index: completer.c
===================================================================
RCS file: /cvs/src/src/gdb/completer.c,v
retrieving revision 1.44
diff -u -p -r1.44 completer.c
--- completer.c 26 Feb 2011 02:07:07 -0000 1.44
+++ completer.c 9 Mar 2011 18:56:24 -0000
@@ -455,7 +455,10 @@ expression_completer (struct cmd_list_el
type = parse_field_expression (text, &fieldname);
}
if (except.reason < 0)
- return NULL;
+ {
+ free (fieldname);
+ return NULL;
+ }
if (fieldname && type)
{
for (;;)