This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] i386-tdep.c, i386_process_record, document fall-through case.


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I'm going to be a little extremist, and I don't really mean what
Joel> I am about to ask, but: If the author of the code does not understand
Joel> the code, and no other maintainer is able to review associated patches,
Joel> is it time to remove that code?

I think the code is understandable, just not as clear as I might like.

In my case the issue here is not understandability but rather laziness:
looking up all the details is a pain, surely somebody else will look at
it sooner than I will, etc.

In sum I think that removing it is somewhat too extremist :)

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]