This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] bfd/i386linux.c, linux_tally_symbols, Check for null return.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "binutils at sourceware dot org" <binutils at sourceware dot org>, rth at redhat dot com
- Date: Sun, 06 Mar 2011 15:18:52 -0800
- Subject: [RFA] bfd/i386linux.c, linux_tally_symbols, Check for null return.
linux_link_hash_lookup may return null.
Checked in 46 out of 53 instances, according to Coverity.
OK?
2011-03-06 Michael Snyder <msnyder@vmware.com>
* i386linux.c (linux_tally_symbols): Check for null return.
Index: i386linux.c
===================================================================
RCS file: /cvs/src/src/bfd/i386linux.c,v
retrieving revision 1.23
diff -u -p -r1.23 i386linux.c
--- i386linux.c 2 Oct 2009 14:40:41 -0000 1.23
+++ i386linux.c 6 Mar 2011 23:13:55 -0000
@@ -491,7 +491,7 @@ linux_tally_symbols (h, data)
use an indirect symbol to get to the real symbol, we add the
fixup anyway, since there are cases where these symbols come
from different shared libraries */
- if (h1 != NULL
+ if (h1 != NULL && h2 != NULL
&& (((h1->root.root.type == bfd_link_hash_defined
|| h1->root.root.type == bfd_link_hash_defweak)
&& ! bfd_is_abs_section (h1->root.root.u.def.section))