This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Include dir intl when building libcommon.a for gdb
> Hmm, not sure if it helps. But this missing -I ../../intl bugged me
> already for a while.
> I used the following patch in Makefile.in in gdb/common/ and I've
> added it to the INCLUDES.
>
> ChangeLog
>
> * common/Makfile.in (INCLUDES): Add -I for intl.
Could you give the initial error message? Was it when building
GDB or GDBserver?
I am going to guess that this was when you were building GDB?
GDBserver does not seem to include intl, as far as I can tell, so
it would suggest, as pointed out by Pedro, that this should be
put in GDB_INCLUDE instead?
But this also suggests that we have some other code that is in
common/ and should not be there. Your patch may fix the symptoms,
but we'll need to look at the root cause as well.
> Index: gdb/common/Makefile.in
> ===================================================================
> --- gdb.orig/common/Makefile.in 2011-03-02 13:20:22.000000000 +0100
> +++ gdb/common/Makefile.in 2011-03-02 13:25:05.509719100 +0100
> @@ -31,7 +31,7 @@ BFD_DIR = ../../bfd
> BFD_SRC = $(srcdir)/$(BFD_DIR)
> BFD_CFLAGS = -I$(BFD_DIR) -I$(BFD_SRC)
>
> -INCLUDES = -I. -I../ -I$(srcdir) -I$(srcdir)/../../include @GDB_INCLUDE@
> +INCLUDES = -I. -I../ -I../../intl -I$(srcdir) -I$(srcdir)/../../include @GDB_INCLUDE@
>
> libcommon_a_OBJS = signals.o $(COMMON_CPU_OBJ)
> libcommon_a_SOURCES = signals.c $(COMMON_CPU_SRC)
--
Joel