This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Michael Snyder <msnyder at vmware dot com>
- Date: Thu, 3 Mar 2011 09:48:21 +0000
- Subject: Re: [commit] cli/cli-script.c, script_from_file, add a break stmt for lint
- References: <4D6EDDBB.9030809@vmware.com>
On Thursday 03 March 2011 00:15:55, Michael Snyder wrote:
> checked in.
> 2011-03-02 Michael Snyder <msnyder@vmware.com>
>
> * cli/cli-script.c (script_from_file): Add break for lint.
> throw_error (e.error,
> _("%s:%d: Error in sourced command file:\n%s"),
> source_file_name, source_line_number, e.message);
> + break; /* lint */
Please don't. Teach lint about the no-return property of throw_error instead.
> default:
> internal_error (__FILE__, __LINE__, _("bad reason"));
> }
--
Pedro Alves