This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] bfd-target.c, target_bfd_reopen, check for error


On Wednesday 02 March 2011 01:03:04, Michael Snyder wrote:
> This is the only instance in which build_section_table is called
> without being checked for error return.
> 
> OK?

build_section_table actually always returns '0' (==success)...
It can throw, though currently only through an internal_error.
The correct thing to do would be to make it return void,
and change all the dead error handling to do cleanups instead
of checking build_section_table's return.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]