This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err

From: Pedro Alves <pedro at codesourcery dot com>
To: gdb-patches at sourceware dot org
Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, msnyder at vmware dot com
Date: Wed, 2 Mar 2011 01:18:03 +0000
Subject: Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err
References: <4D6D8774.3090506@vmware.com> <201103020008.p2208ODO018859@glazunov.sibelius.xs4all.nl>

> > --- linux-nat.c	1 Mar 2011 00:40:22 -0000	1.197
> > +++ linux-nat.c	1 Mar 2011 23:50:34 -0000
> > @@ -4045,7 +4045,7 @@ linux_thread_alive (ptid_t ptid)
> >      fprintf_unfiltered (gdb_stdlog,
> >  			"LLTA: KILL(SIG0) %s (%s)\n",
> >  			target_pid_to_str (ptid),
> > -			err ? safe_strerror (err) : "OK");
> > +			err ? safe_strerror (errno) : "OK");

Not 100% correct.  target_pid_to_str is allowed to
clobber errno (as any function call is).

> >  
> >    if (err != 0)
> >      return 0;
> 

-- 
Pedro Alves

Follow-Ups:
- Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err
  - From: Michael Snyder

References:
- [RFA] linux-nat.c, linux_thread_alive, user errno instead of err
  - From: Michael Snyder
- Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err
  - From: Mark Kettenis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]