This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [fixme] Missing break statement in linux-record.c?
- From: Hui Zhu <teawater at gmail dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 28 Feb 2011 13:40:28 +0800
- Subject: Re: [fixme] Missing break statement in linux-record.c?
- References: <4D697B37.7020109@vmware.com>
Hi Michael,
I think this part need a break.
Thanks for your check.
Best,
Hui
On Sun, Feb 27, 2011 at 06:14, Michael Snyder <msnyder@vmware.com> wrote:
> Hui,
>
> I can't decide if there was meant to be a break statement here.
> Could you take a look please? ?If the fall-through is intentional,
> please just add a comment to say that.
>
> Thanks,
> Michael
>
>
> Index: linux-record.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/linux-record.c,v
> retrieving revision 1.13
> diff -u -p -u -p -r1.13 linux-record.c
> --- linux-record.c ? ? ?1 Jan 2011 15:33:10 -0000 ? ? ? 1.13
> +++ linux-record.c ? ? ?26 Feb 2011 22:12:34 -0000
> @@ -770,6 +770,7 @@ Do you want to stop the program?"),
> ? ? ? ? if (record_linux_sockaddr (regcache, tdep, tmpulongest, len))
> ? ? ? ? ? return -1;
> ? ? ? }
> + ? ? ?/* FIXME --- missing break??? ?Intentional??? ?Comment please ?*/
> ? ? case gdb_sys_recv:
> ? ? ? {
> ? ? ? ? ULONGEST size;
>
>