This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] tracepoint: add new trace command "printf"[1] gdbserver
- From: Tom Tromey <tromey at redhat dot com>
- To: Hui Zhu <teawater at gmail dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 11 Feb 2011 14:31:21 -0700
- Subject: Re: [PATCH] tracepoint: add new trace command "printf"[1] gdbserver
- References: <AANLkTikPdWq8kQWs0f4B3XdYmjHx5LshN5K_Xt=DMx29@mail.gmail.com> <AANLkTim4+iQZHQhFrQBp-dz_jh65KsM45JZ6nR0qnHTi@mail.gmail.com> <AANLkTi=urZAz1paHYCfHj39qX=Q3pQ=PMERAVrfVD+TE@mail.gmail.com>
>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>> To make the gdbserver support %s.
Oops, I missed this when reviewing your earlier patch.
Sorry about that.
>> +int
>> +tp_printf(const char *format, ...)
Space before open paren.
>> + va_end(ap);
Likewise.
>> + argv = (void *)(unsigned long)top;
Spacing.
There are several more spacing bugs, please fix them all.
I didn't go read the other patch to try to deduce the format of the
printf opcode to see if it all makes sense. Documentation would help.
Tom