This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Speed up JIT support
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> Here is the updated patch (applies on top of the [1/2] cosmetic patch).
Paul> Re-tested on linux/x86_64, no regressions.
Thanks for doing this.
Just some nits, nothing serious.
Paul> +/* Per-objfile data private to breakpoint.c */
Period at the end of the comment.
Paul> + /* minimal symbol for "_ovly_debug_event" (if any) */
Paul> + struct minimal_symbol *overlay_msym;
Comments should start with an upper case character and end with a
period. There are a few instances of this.
Paul> +
Paul> +static int
Paul> +msym_not_found_p (const struct minimal_symbol *msym)
This function needs an introductory comment.
This is ok with these things fixed.
Tom