Re: gdb: Incorrect stack unwinding if compressed debug info is used

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Vladimir" == Vladimir Simonov <sv@sw.ru> writes:

Vladimir> Please see attached patch. Hope it explains what I meant under
Vladimir> "change dwarf2_read_section".
Vladimir> If such changes are not acceptable by some reason(performance?,
Vladimir> readability?, something else) then I'm OK with current naming.

I'm sorry I didn't reply to that part of your message the first time.

I think the current code is a bit clearer, because seeing
"dwarf2_read_section" in a conditional seems strange, but seeing
"dwarf2_section_size" does not.

However, it is a minor point.  I would probably approve either patch :-)

Vladimir> I definitely don't insist on such changes, I just interested
Vladimir> in understanding gdb "coding policy". If it is difficult
Vladimir> to explain please ignore this mail.

For something like this it is just a matter of personal taste, unless
some argument emerges to prefer one approach over the other.  I think I
try to defer to other maintainers or to the original patch submitter on
matters of naming, but it is hard to say if that is what I actually do
;-)

Tom