This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Don't assume order of xml attributes
On Wednesday 02 February 2011 16:33:52, Daniel Jacobowitz wrote:
> This was not required. The attributes don't have to be ordered in the
> XML file, but they're ordered in the VEC because we create it that way
> in gdb_start_element. You can tell your patch still relies on this
> code because the calls to the lookup function mostly don't check for
> NULL.
Ah! Thanks for pointing it out. I completely missed it.
>
> That said, I don't think a linear search for attribute names is going
> to be too slow :-)
One would hope. :-)
> So this is a nice readability improvement anyway.
Yeah, I agree. I'll keep it in then.
Thanks,
--
Pedro Alves