This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: s/regcache_valid_p/regcache_register_status; add enum register_status
On Sunday 30 January 2011 03:21:03, Yao Qi wrote:
> On 01/25/2011 08:49 PM, Pedro Alves wrote:
> > 2011-01-25 Pedro Alves <pedro@codesourcery.com>
> >
> > * regcache.c (struct regcache_descr): Rename
> [....]
> > (regcache_valid_p): Rename to ...
> > (regcache_register_status): ... this. Adjust.
>
> All the references to regcache_valid_p should be updated as well.
Aaww, completely missed that.
> GDB native build on ARM is broken.
> cc1: warnings being treated as errors
> ../../src/gdb/arm-linux-nat.c: In function store_fpregister:
> ../../src/gdb/arm-linux-nat.c:193: error: implicit declaration of
> function regcache_valid_p
>
> This patch is to s/regcache_valid_p/regcache_register_status in the rest
> of gdb source files, and fix ARM native build failure.
>
> OK to apply?
Not as is. Please use 'if (regcache_register_status (..) == REG_VALID)'
instead of 'if (regcache_register_status (..)'. Okay with that
change.
Thanks!
--
Pedro Alves