This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Evening up the right margins
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: msnyder at vmware dot com
- Cc: gdb-patches at sourceware dot org, brobecker at adacore dot com
- Date: Wed, 12 Jan 2011 22:28:15 +0100 (CET)
- Subject: Re: [RFA] Evening up the right margins
- References: <4D2D1D4B.9070509@vmware.com>
> Date: Tue, 11 Jan 2011 19:17:31 -0800
> From: Michael Snyder <msnyder@vmware.com>
>
> Mark and Joel, I'm especially interested in your feedback.
>
> This patch is meant to help even up the right margins without adding
> extra lines to the file. If folks approve, I'll do more.
The thought that comes to my mind is "if it ain't broke, don't fix
it". I think the benefit from these changes is marginal. Is this
really worth the extra churn in the repository? It does make diffing
revisions of the affected files more difficult...
So I'd say that making changes like this is fine if you're changing
the text of a comment or the code anyway, but otherwise I'd leave
things alone.