This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [toolchain-devel] [PATCH] sim: allow memory maps to default to mapped files
On Tue, Jan 11, 2011 at 8:04 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tue, Jan 11, 2011 at 10:07, Doug Evans wrote:
>> On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger wrote:
>>> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote:
>>>> OK. ?The patch looks good to me, except for the little formatting nits
>>>> that I already pointed out. But can you give it a few more days for
>>>> others to comment? ?In particular, Doug Evans is more proficient with
>>>> the simulator than I am, I believe (which is not hard, considering
>>>> that I have barely ever touched that code).
>>>
>>> i'll commit in a day or two if no one has any more feedback ...
>>
>> Hi. ?The only comment I have is that it would be nice to keep "struct
>> stat s;" in its original location, but it's not necessary.
>
> i couldnt do that without duplicating the bytes and free_length setup,
> and i thought not duplicating those was more important.
Well, free_length can easily be moved down, it's really only bytes
that's the concern.
It's not worth spending time on it, but having the two ifdefs and having
int a;
#ifdef FOO
int b;
mumble
#endif
feels like it could be cleaner, but for this it's not worth spending time on.