This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: allow memory maps to default to mapped files
- From: Doug Evans <dje at google dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Tue, 11 Jan 2011 07:07:43 -0800
- Subject: Re: [PATCH] sim: allow memory maps to default to mapped files
- References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> <201012280238.03847.vapier@gentoo.org> <20101228120120.GE2436@adacore.com> <201101082239.10670.vapier@gentoo.org>
On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote:
>> OK. ?The patch looks good to me, except for the little formatting nits
>> that I already pointed out. But can you give it a few more days for
>> others to comment? ?In particular, Doug Evans is more proficient with
>> the simulator than I am, I believe (which is not hard, considering
>> that I have barely ever touched that code).
>
> i'll commit in a day or two if no one has any more feedback ...
Hi. The only comment I have is that it would be nice to keep "struct
stat s;" in its original location, but it's not necessary.