This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: allow memory maps to default to mapped files


On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote:
>> OK. ?The patch looks good to me, except for the little formatting nits
>> that I already pointed out. But can you give it a few more days for
>> others to comment? ?In particular, Doug Evans is more proficient with
>> the simulator than I am, I believe (which is not hard, considering
>> that I have barely ever touched that code).
>
> i'll commit in a day or two if no one has any more feedback ...

Hi.  The only comment I have is that it would be nice to keep "struct
stat s;" in its original location, but it's not necessary.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]