This is the mail archive of the
mailing list for the GDB project.
Re: [patch] more comment cleanups
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: msnyder at vmware dot com, eliz at gnu dot org, hjl dot tools at gmail dot com, gdb-patches at sourceware dot org
- Date: Mon, 3 Jan 2011 09:04:29 +0100 (CET)
- Subject: Re: [patch] more comment cleanups
- References: <4D1E60A0.email@example.com> <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl> <AANLkTimc4kNHOfO2B95cyKjN9SN1O_+LQ3O_4FpwZ3rR@mail.gmail.com> <4D1E732E.firstname.lastname@example.org> <email@example.com> <4D1F71B0.firstname.lastname@example.org> <20110103043359.GO2396@adacore.com>
> Date: Mon, 3 Jan 2011 08:33:59 +0400
> From: Joel Brobecker <email@example.com>
> > So what do others think about source lines over 70 columns?
> Enforcing a maximum length of 70 characters seems awfully low to me.
> It's fine if someone decides to use 70 characters for his comments,
> of even his code, but I think that 76 or 78 would give better results.
> I even allow myself to go up to 80 when splitting a line makes it
> particularly ugly and hard to read...
70 characters really isn't that low for comments that start in the
first column; look at a properly typeset book and count the number of
characters per line. However, I fully agree with you that it
shouldn't be strictly enforced. If for example, it means that you end
up wrapping a single line comment such that you end up with a single
word on the next line I strongly prefer not to wrap and keep the
comment on one line such that it takes up less vertical space.
The same holds for code. If I can keep things on a single line, I'll
attempt to do so, even if it means I'll get a little bit closer to the
80 character "hard" limit. It's one of the reasons I never believed
in running tools like indent to automatically format source code.