This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: allow memory maps to default to mapped files


> I find it annoying when using --memory-mapfile that I also need to look
> up and manually specify the file size to the following --memory-region
> option.  So make a length of 0 in the following --memory-region trigger
> an auto-sizing of the map to the length of the file being mapped.

Generally speaking, and that's not your fault, it would be nice to
have some documentation about this module in the GDB Users' Manual.
Would you be willing to help us in that department? - nothing fancy,
but something very basic that quickly lists all available option
and what they mean.  This can be treated as a separate patch.

In terms of the user interface for this change, why not just make
the size optional? So, either the user specifies "ADDR,SIZE", or
he says "ADDR".  That way, you do not need to treat zero as special.

I see, now, that this patch has already been checked in - I must have
missed the approval email.  But the suggestions are both still interesting,
IMO.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]