This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: proposal: substitute-path handles foreign dir separators
- From: Raphael Zulliger <zulliger at indel dot ch>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 20 Dec 2010 07:38:06 +0100
- Subject: Re: proposal: substitute-path handles foreign dir separators
- References: <4D0B7125.2010203@indel.ch> <834oach14b.fsf@gnu.org>
On 17.12.2010 16:26, Eli Zaretskii wrote:
There were discussions on this a few months ago, you may wish to look
them up.
I just tried to look it up but I couldn't find the particular discussion
unless you refer to the one mentioned by Pedor Alves:
<http://sourceware.org/ml/gdb-patches/2010-04/msg00759.html>
This isn't the right way, for 2 reasons:
. It makes the code uglier than it must be.
. The support for DOS-style file names is based on compile-time
macros, so it cannot be turned on and off. Thus, you leave no fire
escape for Unix users who just happen to have file names with
literal backslashes, improbable as that may be.
I agree with both. I didn't thought about the case of using escaped file
names on Unix systems.
In this part, I simply don't understand why you needed the
HAVE_DOS_BASED_FILE_SYSTEM branch. DOS/Windows file-system calls
support forward slashes just fine, so there's no need to rewrite the
slashes.
Thanks. Somehow I wasn't aware of that.
Finally, please wait for other opinions, as I'm not sure mine is in
consensus.
I think we should forget about my patch as I posted it. Let's continue
the discussion based on Pedros patch instead.
Thanks.
Raphael