This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Improve amd64 prologue analysis
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: pierre dot muller at ics-cnrs dot unistra dot fr, gdb-patches at sourceware dot org
- Date: Thu, 16 Dec 2010 08:15:30 +0400
- Subject: Re: [RFC] Improve amd64 prologue analysis
- References: <001701cb84ea$6883c170$398b4450$@muller@ics-cnrs.unistra.fr> <20101118172209.GE2634@adacore.com> <004201cb87c1$dab95cd0$902c1670$@muller@ics-cnrs.unistra.fr> <20101119172011.GI2634@adacore.com> <000901cb883c$067a8860$136f9920$@muller@ics-cnrs.unistra.fr> <20101214070535.GO2596@adacore.com> <201012152306.oBFN6x6N019463@glazunov.sibelius.xs4all.nl>
> I hope you'll understand my reluctance to add one after managing 7
> years or so without.
OK - that's very reasonable. Prologue analyzers are very ugly, and
the amd64 one is worse, because the insns are harder to parse
(at least to me). That's why, until Pierre started sending patches,
I never really considered submitting the changes we made, thinking
that we were the only one for whom it actually made a difference.
> So if support for pdata/xdata gets added I would expect that
> the prologue analyzer won't be needed on 64-bit Windows either.
That's correct.
> If you stick it somewhere where I don't need to look at it, I won't
> care as much.
Sounds like an acceptable compromise.
--
Joel