This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] mips-tdep.c: Fix mips16 bit rot
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Dec 2010 09:39:15 +0400
- Subject: Re: [RFC] mips-tdep.c: Fix mips16 bit rot
- References: <20101213170635.6f0c4356@mesquite.lan>
> Comments?
>
> * mips-tdep.c (make_mips16_addr): New function.
> (mips_elf_make_msymbol_special): Don't set the low bit in the
> symbol's address.
> (mips_read_pc, mips_unwind_pc, mips_addr_bits_remove): Strip bit
> indicating mips16 address, if present.
> (mips_write_pc): Set bit indicating mips16 address when in a mips16
> function.
> (mips_eabi_push_dummy_call, mips_o64_push_dummy_call): Likewise,
> but for each function pointer argument to inferior function call.
I'm not a mips expert, but the changes look reasonable to me, and they
should only affect mips16 (at least in theory). I'd probably wait a few
more days to give others a chance to comment, but it otherwise seems OK
to me.
--
Joel