This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] gdb: gdbserver: bfin: new port
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, pedro at codesourcery dot com
- Date: Wed, 8 Dec 2010 22:38:36 +0100
- Subject: Re: [PATCH 2/2] gdb: gdbserver: bfin: new port
- References: <1289867547-19134-1-git-send-email-vapier@gentoo.org> <1289867547-19134-2-git-send-email-vapier@gentoo.org>
> gdb/:
> 2010-11-16 Jie Zhang <jie.zhang@analog.com>
>
> * configure.tgt (bfin-*-*): Set build_gdbserver to yes.
> * NEWS: Mention new Blackfin support.
> * regformats/reg-bfin.dat: New file.
>
> gdbserver/:
> 2010-11-16 Jie Zhang <jie.zhang@analog.com>
>
> * configure.srv (bfin-*-*): Handle bfin targets.
> * linux-bfin-low.c: New file.
> * linux-low.c: Define PT_TEXT_ADDR, PT_TEXT_END_ADDR, and
> PT_DATA_ADDR for BFIN targets.
> * Makefile.in (SFILES): Add linux-bfin-low.c.
> (clean): Remove reg-bfin.c.
> (linux-bfin-low.o, reg-bfin.o, reg-bfin.c): New targets.
> * README: Mention supported Blackfin targets.
The best person to approve your change is either Daniel or Pedro.
Pedro has been doing most of the approvals in that area, lately.
Nonetheless, I had a look.
Overall, I don't see anything wrong with the code.
> +#define bfin_num_regs (sizeof(bfin_regmap) / sizeof(bfin_regmap[0]))
You can use ARRAY_SIZE.
> + unsigned long pc;
> + collect_register_by_name (regcache, "pc", &pc);
> + return pc;
Empty line after local variable declarations... There are several
instances in your patch.
--
Joel