Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)

[Pedro Alves <pedro at codesourcery dot com>]

On Tuesday 23 November 2010 17:22:48, Phil Muldoon wrote:
> Pedro Alves <pedro@codesourcery.com> writes:

> > Here's a patch.  We can move the PyObject fallback typedef from defs.h
> > to varobj.c again.  I haven't looked to see if the PyObject pointers
> > in struct varobj have some other concrete type we could forward
> > declare instead.  Or why don't we #ifdef out those fields if building
> > without python.
> >
> > Tested by building gdb with and without --with-python=no.
> 
> I've no objection really, but wouldn't the PyObject typedef be better
> suited to defs.h?

It's only necessary in one file, and this is how it was before.
IMO, keeping it contained hints that we should avoid putting
uses of the type in core interfaces.

-- 
Pedro Alves