This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, V850] Add support for V850E2 and V850E2V3
On Tue, 21 Sep 2010 13:50:05 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> > - E_R64_REGNUM, E_PC_REGNUM = E_R64_REGNUM,
> > +
> > + /* mpu0 system registers */
> > + E_R64_REGNUM,
> [...]
> > + /* pc etc. */
> > + E_R148_REGNUM, E_PC_REGNUM = E_R148_REGNUM,
> > + E_R149_REGNUM,
>
> Why are you changing the register number for E_PC_REGNUM? I
> assume you've already changed gcc so that the dwarf2 return address
> column ends up being this new number. Won't this make it impossible
> to use an old compiler with a new debugger and vice versa?
Another issue with moving E_PC_REGNUM is that existing debugging stubs
use the old value.
In my opinion, you should be leaving the register order and names
the same for the existing v850 architectures.
Kevin