This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Change to pre-expand symtabs

From: Keith Seitz <keiths at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
Date: Tue, 07 Sep 2010 14:00:54 -0700
Subject: Re: [RFA] Change to pre-expand symtabs
References: <4C4DD835.7060702@redhat.com> <m34oe9b150.fsf@fleche.redhat.com> <4C7FFC68.8080702@redhat.com> <20100904134451.GA6173@host1.dyn.jankratochvil.net>

On 09/04/2010 06:44 AM, Jan Kratochvil wrote:

I find such static buffer as needlessly dangerous, in general, without
thinking too much more.

Actually, I think I rushed this patch out. Tom and I were chatting on IRC. In the context of the patch I was developing then, this was a feasible solution.

However, at Tom's suggestion, I moved some things around, and completely forgot to move the memory allocation around with it. My bad.

Good catch, Jan.

I've attached an updated version of this.

Thank you for looking,

Keith

Attachment: expand-psymtabs-overloaded-3.patch
Description: Text document

References:
- Re: [RFA] Change to pre-expand symtabs
  - From: Tom Tromey
- Re: [RFA] Change to pre-expand symtabs
  - From: Keith Seitz
- Re: [RFA] Change to pre-expand symtabs
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]