Re: [RFA] Change to pre-expand symtabs

[Keith Seitz <keiths at redhat dot com>]

On 09/01/2010 02:32 PM, Tom Tromey wrote:
> I'm afraid I am going to kick this one back to you.
>
> As we discussed on irc, it has problems if the searched-for name
> includes a paren that is not used to enclose the function arguments.

Here is a revised version of this patch which should eliminate this 
problem completely. If the search name contains a '(' (for C++/Java), we 
pass it to cp_remove_params to strip that information. I tested this 
with your example, and it parses that properly.

[Reminder: This is only the part of the patch requiring changes. The 
testsuite patch is still in play. This also requires my earlier patch 
for match_transparent_type to be regression-free.]

Tested on x86_64-linux: no regressions.

Comments?

Keith

ChangeLog
2010-09-02  Keith Seitz  <keiths@redhat.com>

	PR symtab/11743 (partial):
	* psymtab.c (lookup_symbol_aux_psymtabs): Always return NULL;
	switching to pre-expanding symtabs instead.
	(expand_one_symtab_matching_psymtab): Implement.
	* symtab.c (psymtab_search_name): New function.
	(lookup_symbol_aux_symtabs): Use psymtab_search_name for
	psymtab searches.
	(basic_lookup_transparent_type): Likewise.

Attachment: expand-psymtabs-overloaded-2.patch
Description: Text document