This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Your INTERMEDIATE_ENCODING patch for Solaris
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 02 Sep 2010 09:35:44 -0600
- Subject: Re: Your INTERMEDIATE_ENCODING patch for Solaris
- References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <m37hk4x5r0.fsf@fleche.redhat.com> <m3eidxi069.fsf@fleche.redhat.com> <20100817184407.GC3599@adacore.com> <m3aaolgj0g.fsf@fleche.redhat.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <m38w43dho9.fsf@fleche.redhat.com> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <m34oeq8u1g.fsf@fleche.redhat.com> <m339twkmj5.fsf@fleche.redhat.com> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <m3k4n6hgqe.fsf@fleche.redhat.com> <44796.6229789474$1283326243@news.gmane.org> <m362yp9kaj.fsf@fleche.redhat.com> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr>
Pierre> Probably just define PHONY_ICONV if the first set of conditions is
Pierre> not met (by the way, I am not sure the libiconv version test
Pierre> that we added is really pertinent.)
Thanks. I think I got the logic wrong:
+/* If we got here and have wchar_t support, we might be on a system
+ with some problem. So, we just disable everything. */
+#if !(defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC))
+#define PHONY_ICONV
+#endif
I think that "!" is wrong -- it even contradicts the comment.
I'm sorry to keep bothering you about this, but could you remove that
"!" and try again?
Tom